Path to font-awesome-stylus in app.styl is not correct + offer

angular-fullstack / generator-angular-fullstack

Yeoman generator for an Angular app with an Express server

https://awk34.gitbook.io/generator-angular-fullstack

6.12k stars 1.24k forks source link

Path to font-awesome-stylus in app.styl is not correct + offer #2566

Open verbart opened 7 years ago

verbart commented 7 years ago

[x] I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.

Item	Version
generator-angular-fullstack	4.2.0

Item	Answer
CSS	CSS / LESS / SCSS / Stylus

Replace it - @import '~font-awesome-stylus/stylus/index' To - @import '~font-awesome-stylus/index'

Offer: Stylus knows how to include the CSS code, so the font-awesome-stylus is unnecessary. Just use original fontawesome packge, and his css file.

Awk34 commented 7 years ago

I made a bug report here: https://github.com/raulghm/Font-Awesome-Stylus/issues/35

Awk34 commented 7 years ago

We included it as a nice-to-have, since the stylus copy of FA also includes stylus mixins. We don't actually use any of the mixins in the generated code AFAIK, so we could easily just use the regular FA library.