search

angular-fullstack / generator-angular-fullstack

Yeoman generator for an Angular app with an Express server
https://awk34.gitbook.io/generator-angular-fullstack
6.12k stars 1.24k forks source link

Page Speed score #440

Open meeDamian opened 10 years ago

meeDamian commented 10 years ago

https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Ffullstack-demo.herokuapp.com%2F&

Currently we score:

I bet we can do better! ;)

There are some things that can be fixed quite easily:

I wouldn't bother with above-the-fold stuff as that's the first thing anyone using this generator will change (unless there's a grunt plugin that can handle that somehow).

Also is https://fullstack-demo.herokuapp.com kept up-to-date with releases? @DaftMonk since you're the maintainer, how about adding buildcontrol:heroku task to generator's Gruntfile?

DaftMonk commented 10 years ago

I'm not sure how to use a minified/compressed socket.io.js, because we're using the one that socket.io itself serves up. Maybe theres a setting to enable compression, but I'm not sure about minification. We could use a bower install and minify it ourselves, but that seems counter to the way socket io wants you to serve the client js.

I definitely need to automate the rebuild and deployment of the fullstack demo. I could probably add it as part of the grunt task for when a new version is released to build and publish the demo again.

JaKXz commented 10 years ago

@DaftMonk the only thing I was going to add to your comment is that the demo should show which version it was built with in the footer. Also, @chester1000 you should add #412 to the list.

meeDamian commented 10 years ago

@JaKXz Agree.

I just copied ones from Page Speed, but it will be great if we completed this list with others as well, indeed :)

JaKXz commented 10 years ago

Would it be overkill to have a few different combinations of setups (e.g. with/without mongo, with/without socketio) in different branches in the demo repo? They would of course be deployed to different heroku and openshift addresses.

EDIT: the recent fix for cdnify will also help, you could add and mark that as completed.

kingcody commented 10 years ago

@DaftMonk, @chester1000 take a look at this branch: feature/baked-in-socket.io

I serve the socket.io.js client file with the default socket.io server when in development env, but when built we minify it into vendor.js and simply tell the socket.io server to not serve the client.

I think i was able to keep it pretty simple and fairly lite in changes. Let me know if you think it would be suitable for a PR.

@chester1000, not sure if you had started working on this or not. Just hoped i might be able to help a lil (:

kingcody commented 10 years ago

Also, I thought the JS was already in the <body>. Correct me if I'm wrong.

DaftMonk commented 10 years ago

I've added a grunt task to automate building and deployment of the demo. Not sure if we need different setups, seems a bit like overkill to me, but it wouldn't be hard to add now.

@kingcody Nice solution. That would be welcome in a PR.

kingcody commented 10 years ago

@DaftMonk to canary I presume?

DaftMonk commented 10 years ago

@kingcody I think this is a small enough feature that it could go into master, as part of a patch.