search

angular-fullstack / generator-angular-fullstack

Yeoman generator for an Angular app with an Express server
https://awk34.gitbook.io/generator-angular-fullstack
6.12k stars 1.23k forks source link

Have a component for file-uploading #966

Open chinnichaitanya opened 9 years ago

chinnichaitanya commented 9 years ago

File Uploading is used in almost every app. So why not have a component for that ?

vicky-gonsalves commented 9 years ago

I don't think there is a need of component for file uploading. As we have large repository of plugins for file uploading on bower/npm.. Also its user dependent, so each one can have their own taste.

Awk34 commented 9 years ago

There would need to be a lot of options, like GridFS, filesystem, SQL, maybe even cloud..

chinnichaitanya commented 9 years ago

I think GridFS is promising. For storing in filesystem, we need to take care some security measures like first storing it in a temp folder and then storing it in actual folder.

kingcody commented 9 years ago

@chinnichaitanya do you have a proposal or PR that you would like to offer?

In my personal opinion this seems a little bit out of the scope of the generator, also as @vicky-gonsalves mentioned there are so many plugins/methods that could be used to implement it; I don't feel that it would be easy to satisfy and support a majority of the users.

Another idea might be to include a file uploading component via a sub-generator. @chinnichaitanya is that something you have expirence with by chance?

Awk34 commented 9 years ago

@kingcody I've got some ideas for how it would be implemented. I'll PM you.

chinnichaitanya commented 9 years ago

@kingcody As of now, I don't have any PR to offer. What I meant is having multiple options i.e, asking if the user wants uploading through GridFS or filesystem similar to asking whether we want authentication using google or facebook or twitter etc.

And I didn't understand what does a sub-generator means. Can you explain me what it is ?

@Awk34 Thanks for adding it to the 2.3.0 milestone.