angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.29k stars 6.72k forks source link

virtual-scroll: support multiple items per row #10114

Open mmalerba opened 6 years ago

mmalerba commented 6 years ago

Allow the user to specify the number of items per row in the fixed size scrolling strategy

filipemendes1994 commented 5 years ago

@mmalerba any news about this?

mmalerba commented 5 years ago

Most of our effort is focused on integrating with MDC right now. When I have time to do more work on virtual scroll, finishing up the missing parts of the autosize strategy will be my top priority , so this one might have to wait a while

bebeto84 commented 4 years ago

Hi @mmalerba any updates on this? Is there at least prevision if this feature will be on the pipeline?

Thanks!

pl4yradam commented 4 years ago

+1 this would be amazing

SvenBudak commented 4 years ago

Any news about this? it seems it's currently not possible to build a real world contentful app with angular. :/

SurenAvagyanG commented 4 years ago

please give any update of possible

tdhulster commented 4 years ago

In the meantime you can use display:grid by overriding the css

::ng-deep{
  .cdk-virtual-scroll-content-wrapper {
    display: grid;
    grid-template-columns: 50% 50%;
  }
}
hdadr commented 4 years ago

Any update on this?

daniel-halldorsson commented 4 years ago

I got issues trying to use the display: grid technique above, it looked like it would work but then found it would randomly jump back to previously scrolled locations and was unusable. Official support for multi column would be amazing, +1

SvenBudak commented 4 years ago

We solve it with modulo operator...

mmalerba commented 4 years ago

The team does plan to work on this (and other virtual scroll features), but it won't happen this quarter. Our current areas of focus are component harnesses, integration with MDC Web, and the date range picker

daniel-halldorsson commented 4 years ago

Great news, in the mean time, i solved it by chunking my data and wrapping it in a row component with a fixed height. I used BreakpointObserver from cdk layout to determine the amount of chunking required (ie. 1 thumbnail per row on mobile, up to 8 on desktop, depending on width)

daniel-halldorsson commented 4 years ago

We solve it with modulo operator...

can you give some more information on that?

Albertbol commented 4 years ago

Up

lincolnthree commented 3 years ago

https://github.com/rintoj/ngx-virtual-scroller Has an implementation of multiple items per row, if anyone wants to look at how it's done (or get something working today.)

enesien commented 3 years ago

I was able to "chunk" my array into rows with 4 items each. Then the cdkVirtualFor becomes your rows, your [itemSize] becomes the height of the row, and you loop over the "columns" inside the virtualfor.

      let i: number, j: number, temparray: Card[][] = [], chunk = 4;
      for (i = 0, j = r.length; i < j; i += chunk) {
        temparray.push(r.slice(i, i + chunk));
      }
      this.all = temparray;
        <cdk-virtual-scroll-viewport class="h-100" [itemSize]="130">
            <div class="row no-gutters" *cdkVirtualFor="let row of all">
                <div class="col-3" *ngFor="let card of row">
                    <card-image [card]="card"></card-image>
                </div>
            </div>
        </cdk-virtual-scroll-viewport>
michele-bergia commented 3 years ago

Is there any workaround to have multiple items per row when having *cdkVirtualFor working with DataSource<T>?

joharzmn commented 3 years ago

Any Update on this?

timsar2 commented 3 years ago

?

laurent67100 commented 3 years ago

That would be a really helpful feature. Trying to build a responsive resizable css grid gallery with virtual scroll. Thanks!

samhoseinkhani commented 3 years ago

@mmalerba would you accept any PRs on this issue?

mmalerba commented 3 years ago

Yes, I'd be happy to accept a community PR for this. Before you get to far though, it would be good to agree on what the API will look like

tayambamwanza commented 3 years ago

I was able to "chunk" my array into rows with 4 items each. Then the cdkVirtualFor becomes your rows, your [itemSize] becomes the height of the row, and you loop over the "columns" inside the virtualfor.

      let i: number, j: number, temparray: Card[][] = [], chunk = 4;
      for (i = 0, j = r.length; i < j; i += chunk) {
        temparray.push(r.slice(i, i + chunk));
      }
      this.all = temparray;
        <cdk-virtual-scroll-viewport class="h-100" [itemSize]="130">
            <div class="row no-gutters" *cdkVirtualFor="let row of all">
                <div class="col-3" *ngFor="let card of row">
                    <card-image [card]="card"></card-image>
                </div>
            </div>
        </cdk-virtual-scroll-viewport>

@enesien This is a good alternative for the time being, thanks for posting this.

Baluditor commented 3 years ago

I was able to "chunk" my array into rows with 4 items each. Then the cdkVirtualFor becomes your rows, your [itemSize] becomes the height of the row, and you loop over the "columns" inside the virtualfor.

      let i: number, j: number, temparray: Card[][] = [], chunk = 4;
      for (i = 0, j = r.length; i < j; i += chunk) {
        temparray.push(r.slice(i, i + chunk));
      }
      this.all = temparray;
        <cdk-virtual-scroll-viewport class="h-100" [itemSize]="130">
            <div class="row no-gutters" *cdkVirtualFor="let row of all">
                <div class="col-3" *ngFor="let card of row">
                    <card-image [card]="card"></card-image>
                </div>
            </div>
        </cdk-virtual-scroll-viewport>

Thank you for this.

I had to add inline-block to <div class="col-3" *ngFor="let card of row"> get it work.

nerd-cs commented 3 years ago

In the meantime you can use display:grid by overriding the css

::ng-deep{
  .cdk-virtual-scroll-content-wrapper {
    display: grid;
    grid-template-columns: 50% 50%;
  }
}

@tdhulster, @mmalerba This is a good solution, I think

Particularly, we should set itemSize <cdk-virtual-scroll-viewport [itemSize]="itemSize">

If you want 2 columns per row then itemSize = half value of size (in pixels) For the responsiveness, we can use cdk BreakpointObserver, and then we can set itemSize dynamically.

::ng-deep{
    .cdk-virtual-scroll-content-wrapper {
        display: grid;
        grid-template-columns: 1fr 1fr 1fr;

        @media (max-width: 991.98px) {
            grid-template-columns: 1fr 1fr;
        }
        @media (max-width: 575.98px) {
            grid-template-columns: 1fr;
        }
    }
}
constructor() {
    const layoutChanges = breakpointObserver.observe([
                '(max-width: 991.98px) and (min-width: 576px)',
                '(max-width: 575.98px)'
            ]);
    layoutChanges.pipe(takeUntil(this.destroy$))
    .subscribe(res => {
        this.tabletScreen = breakpointObserver.isMatched('(max-width: 991.98px) and (min-width: 576px)');
        this.mobileScreen = breakpointObserver.isMatched('(max-width: 575.98px)');
        this.itemSize = 360 / 3;    // grid-template-columns: 1fr 1fr 1fr; --------- 360px  = item height 
        if (this.tabletScreen) {
            this.itemSize = 360 / 2;   //  grid-template-columns: 1fr 1fr;
        }
        if (this.mobileScreen) {
            this.itemSize = 360;      //  grid-template-columns: 1fr;
        }
    });
}
coldiary commented 2 years ago

In the meantime you can use display:grid by overriding the css

::ng-deep{
  .cdk-virtual-scroll-content-wrapper {
    display: grid;
    grid-template-columns: 50% 50%;
  }
}

@tdhulster, @mmalerba This is a good solution, I think

Particularly, we should set itemSize <cdk-virtual-scroll-viewport [itemSize]="itemSize"> If you want 2 columns per row then itemSize = half value of size (in pixels) For the responsiveness, we can use cdk BreakpointObserver, and then we can set itemSize dynamically.

::ng-deep{
    .cdk-virtual-scroll-content-wrapper {
        display: grid;
        grid-template-columns: 1fr 1fr 1fr;

        @media (max-width: 991.98px) {
            grid-template-columns: 1fr 1fr;
        }
        @media (max-width: 575.98px) {
            grid-template-columns: 1fr;
        }
    }
}
constructor() {
    const layoutChanges = breakpointObserver.observe([
                '(max-width: 991.98px) and (min-width: 576px)',
                '(max-width: 575.98px)'
            ]);
    layoutChanges.pipe(takeWhile(() => this.alive))
    .subscribe(res => {
        this.tabletScreen = breakpointObserver.isMatched('(max-width: 991.98px) and (min-width: 576px)');
        this.mobileScreen = breakpointObserver.isMatched('(max-width: 575.98px)');
        this.itemSize = 360 / 3;    // grid-template-columns: 1fr 1fr 1fr; --------- 360px  = item height 
        if (this.tabletScreen) {
            this.itemSize = 360 / 2;   //  grid-template-columns: 1fr 1fr;
        }
        if (this.mobileScreen) {
            this.itemSize = 360;      //  grid-template-columns: 1fr;
        }
    });
}

I found it does not quite work, as while scroll past the itemSize, the component will unload one item of the viewport from the start, thus breaking the grid flow.

@enesien chunks solution works best, as it would remove a complete row at once.

dtomaszewski commented 2 years ago

Hi, is there any progress on this issue ?

Sampath-Lokuge commented 2 years ago

Yes, we must really need this feature with the Angular Virtual scroller component. At this moment Angular doesn't have any such 2 column grid system scroller. This is a huge issue, especially for large data sets with mobile devices. All other/3rd party component providers also heavily or only depend on Angular Virtual scroller. So we need this from Google Angular team. Any news about progress on this in 2022, please?

Lexa950609 commented 2 years ago

Hi,, any update on above??

zip-fa commented 2 years ago

Bump. Any news? Waiting for grid support. Btw found new lib solving this issue: https://github.com/lVlyke/lithium-ngx-virtual-scroll

gelinger777 commented 2 years ago

bump

tdhulster commented 2 years ago

Are there people interested in developing this together in pair/ensemble maybe?

lincolnthree commented 1 year ago

Bump again. Really need this.

Bump. Any news? Waiting for grid support. Btw found new lib solving this issue: https://github.com/lVlyke/lithium-ngx-virtual-scroll

I'm VERY impressed with this library. It's simple, fairly thin / not a huge dependency, and actually works quite well for the purpose. I think it could use a few small tweaks, but so far in my testing it's been very consistent across browsers. I do not know how well supported it will be on older browsers/devices, since it uses ResizeObserver - but I suspect a simple polyfill would take care of that. It does not use any fancy css, either.

iakovoszournatzis commented 1 year ago

any news?

Sampath-Lokuge commented 1 year ago

Here is a great library for this feature. Please give a git Star to that super-talented guy if you'll use it.

Ref: https://github.com/lVlyke/lithium-ngx-virtual-scroll#readme

kirill-borisyonok commented 4 months ago

@mgechev please, add this function

ultimathei commented 2 months ago

up

ecancil commented 1 month ago

This was opened in 2018. That's a little shocking. Can't believe the grid-list can't even dogfood angulars own virtual scrolling

reboot25 commented 1 month ago

Yes, I'd be happy to accept a community PR for this. Before you get to far though, it would be good to agree on what the API will look like

I implemented MultiColumnVirtualScrollStrategy similar to the FixedSizeVirtualScrollStrategy to achieve this, and here is the demo: https://storybook.jyuan.online/?path=/story/list--multiple-columns. Can I create a PR for this?

lincolnthree commented 1 month ago

Yes, I'd be happy to accept a community PR for this. Before you get to far though, it would be good to agree on what the API will look like

I implemented MultiColumnVirtualScrollStrategy similar to the FixedSizeVirtualScrollStrategy to achieve this, and here is the demo: https://cv.jyuan.online/?path=/story/list--multiple-columns. Can I create a PR for this?

Nice. Does this automatically calculate viewport height? I've been using https://github.com/lVlyke/lithium-ngx-virtual-scroll as someone in this thread previously recommended.

reboot25 commented 1 month ago

@lincolnthree I wrote this according to https://material.angular.io/cdk/scrolling/overview#scrolling-strategies. So it should has the same behavior as FixedSizeVirtualScrollStrategy. In the demo, the viewport height is 100%.

reboot25 commented 1 month ago

Hi @mmalerba,

I merged the latest main branch and added a demo on the dev pages. I also added support to specify the item width in percentages.

Please check the animation below and give some suggestions. It's not a virtual scroll on a grid; it's just list items using flex-wrap that automatically calculate the viewport height and render visible items in view.

Screenshots from https://material-dev.jyuan.online/virtual-scroll fixed-width percentage-width