angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.33k stars 6.73k forks source link

Inline bezier curves instead of using defined constant #11626

Closed talamaska closed 6 years ago

talamaska commented 6 years ago

https://github.com/angular/material2/blob/f826805650113dcbf519084216d24dac89583412/src/lib/tooltip/tooltip-animations.ts#L25 https://github.com/angular/material2/blob/f826805650113dcbf519084216d24dac89583412/src/lib/stepper/stepper-animations.ts#L35

the curves are defined here https://github.com/angular/material2/blob/master/src/lib/core/animation/animation.ts Their usage is inconsistent. I noticed different values in some components. Curves that don't correspond to material.io spec.

andrewseguin commented 6 years ago

Please re-open the issue to report any animations that are not matching the spec and we can review and make fixes as needed. Thanks!

talamaska commented 6 years ago

@andrewseguin so it's not an issue that the beziers are inline strings instead of constants?

talamaska commented 6 years ago

@andrewseguin what about those

$ease-in-out-curve-function: cubic-bezier(0.35, 0, 0.25, 1) !default;

$swift-ease-out-timing-function: cubic-bezier(0.25, 0.8, 0.25, 1) !default;

$swift-ease-in-timing-function: cubic-bezier(0.55, 0, 0.55, 0.2) !default;

I didn't saw any of those defined somewhere in Material guidelines

angular-automatic-lock-bot[bot] commented 5 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.