search

angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.22k stars 6.69k forks source link

sidenav: scroll strategies not working when mat-sidenav-container is used #14996

Open jbojcic1 opened 5 years ago

jbojcic1 commented 5 years ago

What is the expected behavior?

When dialog is opened inside mat-sidenav-container scroll strategies should work as usual. Block should block scrolling when dialog is opened, noop should allow scrolling, etc.

What is the current behavior?

Scroll strategies don't work when mat-sidenav-container is used. If I open dialog with backdrop and noop scroll strategy, scrolling is still blocked. If I remove backdrop and use block strategy, scrolling is still possible.

What are the steps to reproduce?

https://stackblitz.com/edit/angular-material2-issue-effkee

Open dialog and try to scroll. Play around with backdrop and scroll settings.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular, Material and CDK 7.2.2, macos, Chrome (haven't tried other browsers but I assume it's the same)

Is there anything else we should know?

/

intellix commented 5 years ago

I guess related as well: https://github.com/angular/material2/issues/4280

The default ScrollStrategy only stops scrolling on the body right. I guess we'd need a custom ScrollStrategy for MatSideNav and I'd guess that most people expect it to also block Sidenav scrolling.

Perhaps the library could provide a ScrollingStrategy for blocking a Sidenav scroll and support things like scrolling to top on route change

smaillns commented 4 weeks ago

check your :host css