search

angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.34k stars 6.74k forks source link

Button and toggle-button should not contain a `<div>` #16350

Closed ksag-tap closed 2 years ago

ksag-tap commented 5 years ago

Reproduction

https://stackblitz.com/edit/components-issue-utnh8w

Steps to reproduce:

  1. run stackblitz
  2. see html source

Expected Behavior

jelbourn commented 5 years ago

Confirmed that both contain a div which is technically not allowed by the spec, but doesn't actually cause any real problems.

ksag-tap commented 5 years ago

I agree with you, it doesn't cause real problems probably. But I can't say that I adopt WCAG2.0 4.1.1 when using Matelial Button.

crisbeto commented 5 years ago

https://github.com/angular/components/pull/16366

viniciusschuelter commented 2 years ago

this issue need to closed @jelbourn @crisbeto

jelbourn commented 2 years ago

@viniciusschuelter good catch, thanks

angular-automatic-lock-bot[bot] commented 2 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.