Closed Splaktar closed 4 years ago
Seems like this is an issue we always had since introducing snapshot builds. The issue is generally quite rare as not every SHA starts with a leading zero. Definitely a good catch 😄
Here is a fix: #17267
This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
Reproduction
Steps to reproduce:
Expected Behavior
Only valid semver should be used for the versions in https://github.com/angular/material2-docs-content/blob/8.2.x/package.json
Actual Behavior
We’re appending partial commit SHAs to the end of the versions, i.e.
8.2.0-c29c507
,8.2.1-a5d2ed8
, and the latest8.2.2-0462599
.However,
8.2.2-0462599
is not valid semver, so yarn won’t install it.You can check using this validator: https://jubianchi.github.io/semver-check/#/8.2.2-0462599/8.2.2-0462599
The leading
0
is the issue. It doesn’t accept versions like01.02.03
, it has to be1.2.3
.Checking with the
0
removed, says valid semver (https://jubianchi.github.io/semver-check/#/8.2.2-462599/8.2.2-462599).The related commits:
What is seen when trying to build material.angular.io