angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.35k stars 6.74k forks source link

feat(Cdk-FocusTrap): ability to add more overlay detect on EventListenerFocusTrapInertStrategy #19563

Open keatkeat87 opened 4 years ago

keatkeat87 commented 4 years ago

Feature Description

currently EventListenerFocusTrapInertStrategy only base on "div.cdk-overlay-pane" to detect the focus is inside overlay. image but it is not enough when we using third party plugin or our own overlay.

Use Case

1 for example using @tinymce/tinymce-angular it not depend on angular/cdk, so there is no overlay. but it have own implement overlay feature.

for workaround we can totally override a strategy for the case. but maybe angular team can consider add a easy way for that.

crisbeto commented 4 years ago

Adding a selector as an option will definitely solve this case, but it'll be a little clunky as an API. A more long term solution might be to make the focus trap less aggressive in recapturing focus.

angular-robot[bot] commented 2 years ago

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] commented 2 years ago

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.