angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.34k stars 6.74k forks source link

docs-bug(ripple): Incorrectly says that animations will be disabled from NoopAnimationsModule #21541

Closed andrewseguin closed 3 years ago

andrewseguin commented 3 years ago

Documentation Feedback

Documentation for the ripple config's animation value says:

Configuration for the animation duration of the ripples. There are two phases with different durations for the ripples. The animation durations will be overwritten if the NoopAnimationsModule is being used.

However, the implementation gives importance to the input over the module:

animation: {
        ...this._globalOptions.animation,
        ...(this._animationMode === 'NoopAnimations' ? {enterDuration: 0, exitDuration: 0} : {}),
        ...this.animation
      },

Affected documentation page: https://material.angular.io/components/ripple/api#RippleGlobalOptions

angular-automatic-lock-bot[bot] commented 3 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.