angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.36k stars 6.74k forks source link

CDK Platform: Platform should have classification for browsers used on MacOS #21815

Open alphacentauridigital opened 3 years ago

alphacentauridigital commented 3 years ago

Feature Description

Platform should classify MacOS based browsers. The current feature lacks MacOs detection. Additional flag required MACOS:true

Use Case

Open Angular App on macOS Chrome or Safari. The following output log is for Platform on MacOS chrome

ANDROID: false BLINK: true EDGE: false FIREFOX: false IOS: false SAFARI: false TRIDENT: false WEBKIT: false isBrowser: true

Expected Feature:

ANDROID: false BLINK: true EDGE: false FIREFOX: false IOS: false MACOS:true SAFARI: false TRIDENT: false WEBKIT: false isBrowser: true

alphacentauridigital commented 3 years ago

Solution for same can be by adding new property to class in https://github.com/angular/components/blob/master/src/cdk/platform/platform.ts:

MACOS: boolean = this.isBrowser && /Macintosh/i.test(navigator.userAgent) && this.WEBKIT;

angular-robot[bot] commented 2 years ago

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] commented 2 years ago

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.