bug(MatButton): Disable Ripple doesn't stop ripple effect

[SKhalidQ]

Is this a regression?

• [ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

15.2.8

Description

When adding the 'disableRipple' property to a material button, this should stop adding a ripple effect for when the button is clicked. Instead the ripple is still enabled. This was not an issue in previous versions of Angular Material. Have projects with an old version of Angular and Mterial where I have successfully disabled this animation/effect.

Reproduction

Could not get StackBlitz to work with the latest version of Angular Material.

Steps to reproduce:

1. Create a button
2. Add 'mat-button' property to the button
3. Add a 'disableRipple' property to the button
4. Go to the site and click the button

Expected Behavior

Ripple effect should be disabled and not visible when user clicks a material button.

Actual Behavior

Ripple effect is visible when user clicks on a material button.

Environment

• Angular: v16.1.4
• CDK/Material: v16.0.6/v16.1.4
• Browser(s): Tested on Microsoft Edge, Firefox.
• Operating System (e.g. Windows, macOS, Ubuntu): Windows

[wagnermaciel]

Weird that this issue isn't reproducible in our dev-app. I can easily reproduce it on stackblitz and in a new repo

[wagnermaciel]

Hmm, I'm not sure how but I think this was fixed in our latest patch. I created an angular app pointing to a local build of @angular/material and it worked correctly. I'm going to wait for this weeks release and take another look at this

[wagnermaciel]

Update: The issue is still reproducible in 16.1.6. I was testing on our main branch which corresponds to the next minor & major. I should have tested on our patch branch 16.1.x, which is where this issue is reproducible

[wagnermaciel]

Verified that this issue is fixed in 16.1.7

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}