angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.32k stars 6.73k forks source link

bug(mat-slide-toggle): disableRipple not causing any visual changes #28679

Open amysorto opened 6 months ago

amysorto commented 6 months ago

Is this a regression?

The previous version in which this bug was not present was

No response

Description

It looks like disableRipple was used to prevent the ripple animation (ripple based on where in the touch target you clicked) in the legacy components, but now that doesn't seem to show up anymore. So it seems that setting disableRipple isn't causing any difference now.

Reproduction

StackBlitz link: https://stackblitz.com/edit/aakbph?file=src%2Fexample%2Fslide-toggle-overview-example.html

Expected Behavior

Setting disableRipple to true would cause a visual difference upon clicking the slide toggle handle.

Actual Behavior

No viusal change

Environment

burmanp commented 4 months ago

Any more update on this? disableRipple doesn't work on sliders either. I deal with it using css for now like so

.mat-mdc-slider { 
  --mat-mdc-slider-hover-ripple-color: unset; // 'none' also works
  --mat-mdc-slider-focus-ripple-color: unset;
}