search

angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.39k stars 6.76k forks source link

Incorrect breaking change instructions in new release for 2.0.0-beta.3 f396657 #4033

Closed lord0gnome closed 7 years ago

lord0gnome commented 7 years ago

Bug, feature request, or proposal:

Bug/Incorrect instructions

What is the expected behavior?

on this page In the section about MaterialModule being deprecated, it suggests importing import { BrowserAnimationsModule } from @angular/package-browser/animations though for me at least, the correct import is import { BrowserAnimationsModule } from @angular/platform-browser/animations

What are the steps to reproduce?

Try this line import { BrowserAnimationsModule } from @angular/package-browser/animations to get the error because @angular/package-browser/animations doesn't exist and isn't a real NPM package

Which versions of Angular, Material, OS, browsers are affected?

Angular 4.0.1

Material 2.0.0-beta.3

Is there anything else we should know?

My first issue, probably poorly formatted/structured, happy to get feedback!

Stexxen commented 7 years ago

I let my IDE (webstorm) auto import, and it also chose @angular/platform-browser/animations

Nikki1993 commented 7 years ago

Already reported & fixed on master branch https://github.com/angular/material2/commit/b1e5ff6d4f2a8b063976301a13644ad4eb0cdbb1

lord0gnome commented 7 years ago

Oh. Sorry about that then!

On Tue, Apr 11, 2017, 6:50 PM Nikki Kononov notifications@github.com wrote:

Already reported & fixed on master branch b1e5ff6 https://github.com/angular/material2/commit/b1e5ff6d4f2a8b063976301a13644ad4eb0cdbb1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angular/material2/issues/4033#issuecomment-293325321, or mute the thread https://github.com/notifications/unsubscribe-auth/APY7v4lJIjxeOFMEBe7VPdGo4sdoanZXks5ru687gaJpZM4M6I1J .

jelbourn commented 7 years ago

Fixed in b1e5ff6, will redeploy the docs site soon.

angular-automatic-lock-bot[bot] commented 5 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.