search

angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.23k stars 6.7k forks source link

select: increasing font size of select increases font size of options, reseting it back to base value messes up positioning #7637

Open fxck opened 6 years ago

fxck commented 6 years ago

https://stackblitz.com/edit/angular-material2-issue-d1e88y?file=styles.scss

select third option, close, open select again

a) it didn't increase font size of option pre form-field b) positioning was working correctly, despite different font size, pre form-field

cc @crisbeto

fxck commented 6 years ago

In case you are wondering why would I want different item size for options and select

image

there's no reason why would I want the options to be as big as the active option, quite the opposite, it would look pretty bad, and be pretty bad UX, since barely three options would fit into one "screen".

This is what "broke" it https://github.com/angular/material2/commit/d914cc4ea13ae7080fd0afe5bb55159caff7796e#diff-102eaa94de98ed2cabd87565ba514125R89 @mmalerba

https://github.com/angular/material2/issues/7627 and https://github.com/angular/material2/issues/7638 are both related to the same component, it's nearly impossible to do something like this with material, especially since the mat-form-field stuff, I completely understand components like these are not part of the material spec, but it would be nice if slight style modifications would be even possible, especially when it's just about styling most of the time, not the internal apis.

mmalerba commented 6 years ago

I'll take a look and see if we can do the positioning based on the option size instead of the trigger size, just in case people override it like you're doing.