angular / components

Component infrastructure and Material Design components for Angular
https://material.angular.io
MIT License
24.27k stars 6.71k forks source link

Material2 and Angular 5 HttpClient? #8237

Closed zijianhuang closed 6 years ago

zijianhuang commented 6 years ago

feature request:

Angular 5 is in production since 1st Nov 2017. Angular 5 has Http service deprecated, and is in favor of HttpClient defined in '@angular/common/http': 'npm:@angular/common/bundles/common-http.umd.js'

I have a SPA app with Angular 2/4/5 and Material 2. If I stay with Http, things are just fine. If I adapt HttpClient, Material2 will complain, when trying to download node_modules/@angular/common/bundles/common.umd.js/http which result in 404.

And obviously Material2 Beta 12 is still using the Http service, and material.umd.js is importing @angular/http.

However, eve if I provide the old map: @angular/http': 'npm:@angular/http/bundles/http.umd.js along with new map 'ATangular/common/http': 'npm:@angular/common/bundles/common-http.umd.js' problem remains the same.

What are the steps to reproduce?

Have an Angular 5 utilizing Http while also using Material2 Beta12, things are working. Then replace Http with HttpClient along with respective adjustment in importing, the app will fail to load.

What is the use-case or motivation for changing an existing behavior?

To adapt HttpClient in Angular 5.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 5, Material2 Beta 12

Is there anything else we should know?

Obviously Angular 5 with HttpClient could not co-exist. Please advise in the roadmap about when app developers could really replace Http with HttpClient while using Material2.

zijianhuang commented 6 years ago

5814

6454

dushkostanoeski commented 6 years ago

Can't find the issue, but I read that there will be a new version tomorrow so this should be fixed with that release.

crisbeto commented 6 years ago

Closing as something that’ll be fixed in the next release.

DanPride commented 6 years ago

Please advise on version numbers which resolve this issue. I am on cli 1.5

neilhem commented 6 years ago

npm install @angular/material@5.0.0-rc0

angular-automatic-lock-bot[bot] commented 4 years ago

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.