aniav / ynab-csv

Tool for making your CSV files ready to import into YNAB
https://aniav.github.io/ynab-csv/
MIT License
162 stars 85 forks source link

Added the option to invert the Inflow and Outflow column data when the same column is mapped #13

Closed plu83 closed 5 years ago

plu83 commented 5 years ago

There might be a pull request for the same purpose on the hallofffame repo, but their sample link did not look to work.

Anyway, my bank recently made CSV format the only export option and bill payments were signified as a negative amount while charges were positive. With the current version of your fork as linked from the YNAB 4 official documentation, this means charges are considered Inflows while payments were Outflows.

This change results in the presence of an "Invert flows" button when the Outflow and Inflow columns are mapped to the same value. Clicking on it will place charges and payments under the correct column for my bank.

aniav commented 5 years ago

Thanks for the changes! I have moved the button to be placed on the table with data, so it's more obvious it's there for data manipulation 🎉

ynab_csv_converter
aniav commented 5 years ago

Oh, actually @plu83 this change isn't really required. When you import data to YNAB there is a button to do exactly that... I will remove this change as I don't want this tool to overlap anything you can do in the official YNAB app...

swap_inflow_outflow
plu83 commented 5 years ago

Hi @aniav,

It looks as though the ability to swap flows in YNAB is not part of YNAB 4.3.857. That was the last desktop application release before they switched to a subscription model. Here is a screencap of the import window:

image

As I now have a fork with an environment containing the change, it's okay if you decide to leave it out of your version. Nice revision to move the button into the table header though. I will cherrypick that.

aniav commented 5 years ago

Oh, well I never intended to support the desktop version and had no idea we are discussing an issue on it 😂 But if that's everything it takes to actually support I am happy to leave this change. Thank you for helping with this 🙌😁

plu83 commented 5 years ago

Thanks for keeping this project going!