login btn enhancement - Githubissues

ankitapuri / pixelvibe

This a Pixel-art maker with add-on features.

MIT License

43 stars 95 forks source link

login btn enhancement #398

Closed abhi-bhatra closed 3 years ago

abhi-bhatra commented 3 years ago

Related Issue

Info about the related issue

Closes: #397

Type of change

What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behavior of your code (Write NA if not)

Any unusual behavior of your code

actual

Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[x] Any dependent changes have been merged and published in downstream modules.

ankitapuri commented 3 years ago

@abhi-bhatra what changes have u made in the db.sqlite

abhi-bhatra commented 3 years ago

Hi @ankitapuri thank you for the response. Actually, I have done the change only in two files.

static/css/form.css file
templates/login_new.html I only migrated the database to check the proposed changes. And then, I have directly pulled the code to the Repository and created a PR. If you want, I can do the changes without doing any migrations, hence, this will not do any changes in the Database. And can create a new PR! Anyways, I think its just created the record of my session, when I run it in my local env, nothing changed at all

ankitapuri commented 3 years ago

Yeah okay @abhi-bhatra and also attach the screenshot of the changes that you have made