search

anna-pa-m / Metabolic-EP

Code and data for analysis of metabolic networks
Other
9 stars 3 forks source link

Ci #18

Closed pagnani closed 2 years ago

pagnani commented 2 years ago

I made some small cosmetic changes:

I think with this could be published.

TO BE DONE

  1. We have a strange unrecognized license GNU v3. Worth changing it into more standard MIT?
  2. Did not test the whole Cobra compatibility stuff.
codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e7ef2e3). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   44.79%           
=========================================
  Files             ?        8           
  Lines             ?      576           
  Branches          ?        0           
=========================================
  Hits              ?      258           
  Misses            ?      318           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7ef2e3...3765005. Read the comment docs.

abraunst commented 2 years ago

CI failing with

WARNING: could not import HDF5.exists into MAT
ERROR: LoadError: LoadError: UndefVarError: ColumnNorm not defined
pagnani commented 2 years ago

Ok, made a conditional version call to qr to make it work on 1.5 1.6 1.7

all failures are related to a known problem with ubuntu-latest, and in particular the hdf5 library. It is not that critical.

We eventually should reinsert the COBRA compatibility.

Merging it.

On our way to register the package