search

ansforge / IG-fhir-repertoire-offre-ressources-sante

Définition des spécifications de l'API FHIR pour utiliser le Répertoire national de l’Offre et des Ressources en santé et accompagnement médico-social (ROR).
https://interop.esante.gouv.fr/ig/fhir/ror/
MIT License
2 stars 1 forks source link

Prévoir l'évolution du nouvel IG FrCore #195

Open nriss opened 7 months ago

nriss commented 7 months ago

Description du problème

Des travaux sont en cours côté InteropSanté pour publier un IG FrCore. Il faudra mettre à jour l'héritage une fois publié. https://github.com/Interop-Sante/hl7.fhir.fr.core

sdemeyANS commented 4 months ago

attente publication nouvel IG FR.core

sdemeyANS commented 3 months ago

1ers impacts en modifiant juste la version fr.core en dépendance:

  1. changement URL canonique exemple http://interopsante.org/fhir/StructureDefinition/FrOrganization devient https://hl7.fr/ig/fhir/core/StructureDefinition/fr-core-organization
  2. changement id des ressources : exemple fr-organization devient fr-core-organization
sdemeyANS commented 3 months ago
sdemeyANS commented 3 months ago

nouvelles erreurs: error Slice named idNatSt already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named finess already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named sirene already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named rppsRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named adeliRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#40 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"IDNST"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 49 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 54 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 59 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#4 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 64 error Cannot assign "http://rppsrang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://rppsrang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 65 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#0 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 80 error Cannot assign "http://adelirang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://adelirang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 81

sdemeyANS commented 3 months ago

nouvelles erreurs: error Slice named idNatSt already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named finess already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named sirene already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named rppsRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Slice named adeliRang already exists on element Organization.identifier of ROROrganization File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 39 - 46 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#40 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"IDNST"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 49 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 54 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure to this element; a different uri is already assigned: "http://interopsante.org/CodeSystem/fr-v2-0203". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 59 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#4 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 64 error Cannot assign "http://rppsrang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://rppsrang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 65 error Cannot assign https://mos.esante.gouv.fr/NOS/TRE_G07-TypeIdentifiantStructure/FHIR/TRE-G07-TypeIdentifiantStructure#0 to this element; a different CodeableConcept is already assigned: {"coding":[{"system":"http://interopsante.org/CodeSystem/fr-v2-0203","code":"INTRN"}]}. File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 80 error Cannot assign "http://adelirang.esante.gouv.fr/" to this element; a different uri is already assigned: "https://adelirang.esante.gouv.fr/". File: /home/runner/work/IG-fhir-repertoire-offre-ressources-sante/IG-fhir-repertoire-offre-ressources-sante/igSource/input/fsh/profiles/ROROrganization.fsh Line: 81

sdemeyANS commented 3 months ago
  • [x] supprimer slice déjà définie dans fr.core
  • [x] warning changement http https dans les uri => impact en dev
  • [ ] analyse autre impact dev ? slice vraiment identique?

sushi OK

sdemeyANS commented 3 months ago
sdemeyANS commented 3 months ago
  • [x] supprimer slice déjà définie dans fr.core

par contre slice fr.core moins complète que celle du ROR : https://github.com/Interop-Sante/hl7.fhir.fr.core/issues/151

nriss commented 3 months ago

Je pense que le niveau de complétude est le même, j'ai juste défini une slice pour dire les deux types de numéros

sdemeyANS commented 3 months ago

Je pense que le niveau de complétude est le même, j'ai juste défini une slice pour dire les deux types de numéros

moins précise alors car cela ne distingue pas SIREN et SIRET :)

nriss commented 3 months ago

Si, on peut distinguer via le type et via le nombre de caractère dans chacun des numéros :)

sdemeyANS commented 3 months ago

Si, on peut distinguer via le type et via le nombre de caractère dans chacun des numéros :)

distinction plus faible et plus difficile à valider / implémenter à mon avis :)

sdemeyANS commented 3 months ago

fr. core

ROR

devrait résoudre aussi cette issue #187

sdemeyANS commented 3 months ago
sdemeyANS commented 3 months ago
  • [x] héritage fr-core-healthcare-service 1er impact : modifier reference vers Location

nécessite héritage fr-core-location => ok

sdemeyANS commented 3 months ago

nouvelle itération résultat validator : https://github.com/ansforge/IG-fhir-repertoire-offre-ressources-sante/actions/runs/8542708940

reste à voir ./fsh-generated/resources/StructureDefinition-ror-organization.json 05:27:32 [-1, -1] StructureDefinition.differential.element[20]: Error - No match found for Organization.extension:organization-period.value[x].start in the generated snapshot: check that the path and definitions are legal in the differential (including order) [-1, -1] StructureDefinition.differential.element[21]: Error - No match found for Organization.extension:organization-period.value[x].end in the generated snapshot: check that the path and definitions are legal in the differential (including order) [-1, -1] StructureDefinition: Error - The profile https://interop.esante.gouv.fr/ig/fhir/ror/StructureDefinition/ror-organization has 2 elements in the differential (id: Organization.extension:organization-period.value[x].start, id: Organization.extension:organization-period.value[x].end) that don't have a matching element in the snapshot: check that the path and definitions are legal in the differential (including order)

sdemeyANS commented 3 months ago
  1. modification des ref (comme pour les héritages précédents)
  2. un warning sushi : Sushi: warn At least one slice of Practitioner.identifier has a max greater than the overall element max. The max of the following slice(s) has been reduced to match the max of Practitioner.identifier: rpps,adeli (00:04.685 / 00:11.239, 26Mb) et au niveau validator [-1, -1] StructureDefinition.snapshot.element[21]: Information - The slice definition for Practitioner.identifier has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended
sdemeyANS commented 3 months ago
  1. modification des ref (comme pour les héritages précédents)
  2. un warning sushi : Sushi: warn At least one slice of Practitioner.identifier has a max greater than the overall element max. The max of the following slice(s) has been reduced to match the max of Practitioner.identifier: rpps,adeli (00:04.685 / 00:11.239, 26Mb) et au niveau validator [-1, -1] StructureDefinition.snapshot.element[21]: Information - The slice definition for Practitioner.identifier has a maximum of 1 but the slices add up to a maximum of 3. Check that this is what is intended

=> modification pour prendre en compte la slice héritée sur identifier https://github.com/ansforge/IG-fhir-repertoire-offre-ressources-sante/actions/runs/8552382643 => OK

sdemeyANS commented 3 months ago
  1. https://hl7.fr/ig/fhir/core/StructureDefinition-fr-core-practitioner-role-exercice.html
  2. https://hl7.fr/ig/fhir/core/StructureDefinition-fr-core-practitioner-role-profession.html

A voir lequel correspond le mieux au ROR au niveau fonctionnel ou aucun des 2

sdemeyANS commented 1 month ago

impact aussi https://github.com/ansforge/IG-fhir-repertoire-offre-ressources-sante/issues/61#issuecomment-2147665636