ansible-collections / dellemc.enterprise_sonic

Ansible Network Collection for Enterprise SONiC Distribution by Dell Technologies
GNU General Public License v3.0
44 stars 64 forks source link

Sanity tests failing in dellemc.enterprise_sonic #75

Closed dmsimard closed 2 years ago

dmsimard commented 2 years ago
SUMMARY

We are running sanity tests across every collection included in the Ansible community package (as part of this issue) and found that ansible-test sanity --docker against dellemc.enterprise_sonic 1.1.0 fails with ansible-core 2.13.0rc1 in ansible 6.0.0a2.

ISSUE TYPE
COMPONENT NAME

n/a

ANSIBLE VERSION
ansible [core 2.13.0rc1]
COLLECTION VERSION
1.1.0
STEPS TO REPRODUCE
ansible-test sanity --docker
EXPECTED RESULTS

Tests are either passing or ignored.

ACTUAL RESULTS
ERROR: Found 1 action-plugin-docs issue(s) which need to be resolved:
ERROR: plugins/action/sonic.py:0:0: action plugin has no matching module to provide documentation
ERROR: Found 8 validate-modules issue(s) which need to be resolved:
ERROR: plugins/cliconf/sonic.py:0:0: invalid-documentation: DOCUMENTATION.cliconf: extra keys not allowed @ data['cliconf']. Got 'sonic'
ERROR: plugins/cliconf/sonic.py:0:0: invalid-documentation: DOCUMENTATION.name: required key not provided @ data['name']. Got None
ERROR: plugins/httpapi/sonic.py:0:0: invalid-documentation: DOCUMENTATION.author: Invalid author for dictionary value @ data['author']. Got 'Ansible Networking Team'
ERROR: plugins/httpapi/sonic.py:0:0: invalid-documentation: DOCUMENTATION.httpapi: extra keys not allowed @ data['httpapi']. Got 'sonic'
ERROR: plugins/httpapi/sonic.py:0:0: invalid-documentation: DOCUMENTATION.name: required key not provided @ data['name']. Got None
ERROR: plugins/modules/sonic_command.py:0:0: invalid-documentation-markup: DOCUMENTATION.description: Directive "M(sonic_config)" must contain a FQCN for dictionary value @ data['description']. Got ['Runs commands on remote devices running Enterprise SONiC Distribution by Dell Technologies. Sends arbitrary commands to an Enterprise SONiC node and returns the results that are read from the device. This module includes an argument that causes the module to wait for a specific condition before returning or time out if the condition is not met.', 'This module does not support running commands in configuration mode. To configure SONiC devices, use M(sonic_config).']
ERROR: plugins/modules/sonic_facts.py:0:0: invalid-documentation-markup: DOCUMENTATION.options.gather_network_resources.description: Directive "M(!)" must contain a FQCN for dictionary value @ data['options']['gather_network_resources']['description']. Got ["When supplied, this argument restricts the facts collected to a given subset. Possible values for this argument include all and the resources like 'all', 'interfaces', 'vlans', 'lag_interfaces', 'l2_interfaces', 'l3_interfaces'. Can specify a list of values to include a larger subset. Values can also be used with an initial C(M(!)) to specify that a specific subset should not be collected."]
ERROR: plugins/modules/sonic_facts.py:0:0: invalid-documentation-markup: DOCUMENTATION.options.gather_subset.description: Directive "M(!)" must contain a FQCN for dictionary value @ data['options']['gather_subset']['description']. Got ['When supplied, this argument restricts the facts collected to a given subset. Possible values for this argument include all, min, hardware, config, legacy, and interfaces. Can specify a list of values to include a larger subset. Values can also be used with an initial C(M(!)) to specify that a specific subset should not be collected.']
ERROR: The 2 sanity test(s) listed below (out of 43) failed. See error output above for details.
action-plugin-docs
validate-modules
ERROR: Command "podman exec ansible-test-controller-YRxKRHwq /usr/bin/env ANSIBLE_TEST_CONTENT_ROOT=/root/ansible_collections/dellemc/enterprise_sonic LC_ALL=en_US.UTF-8 /usr/bin/python3.10 /root/ansible/bin/ansible-test sanity --containers '{}' --skip-test pylint --metadata tests/output/.tmp/metadata-0xrarmuu.json --truncate 0 --color no --host-path tests/output/.tmp/host-t6a8dtjw" returned exit status 1.
stalabi1 commented 2 years ago

The sanity tests failures will be resolved in upcoming release.

sanity_test.txt