Arc currently need start,end,centre,radius. On first inspection it seems that only centre or radius is required to fully define the arc however this is not the case:
2 valid solutions for start/end/centre
These are both valid solutions for arc with start/end/rad
We have some options:
force user to specify direction of arc
Assume arc smaller than 180 degrees
I've tried to implement idea 2 whilst still allowing user to force arc with greater than 180 deg by using all 4 params.
Nice side effect of these changes is that centre coord can become a property rather than a class object. This means rotation/translation can be handled by parent Entity class in same way for both arc and Line.
Hoping this makes the most sense as rounding corners etc is very simple when you only have to provide start/end/radius
Arc currently need start,end,centre,radius. On first inspection it seems that only centre or radius is required to fully define the arc however this is not the case:
2 valid solutions for start/end/centre![image](https://github.com/ansys/pymotorcad/assets/80680946/80221630-ad82-4f47-82d8-a9101f3ddcc9)
These are both valid solutions for arc with start/end/rad![image](https://github.com/ansys/pymotorcad/assets/80680946/3faffec0-0cbb-4fcf-8239-e9e60c48e58a)
We have some options:
I've tried to implement idea 2 whilst still allowing user to force arc with greater than 180 deg by using all 4 params.
Nice side effect of these changes is that centre coord can become a property rather than a class object. This means rotation/translation can be handled by parent Entity class in same way for both arc and Line.
Hoping this makes the most sense as rounding corners etc is very simple when you only have to provide start/end/radius