ansys / pymotorcad

https://motorcad.docs.pyansys.com
MIT License
13 stars 1 forks source link

Feat/add pymotorcad methods for transient #327

Open DragosVMosteanu opened 1 month ago

DragosVMosteanu commented 1 month ago

added thermal solution type to load_results and save_results also added input check and version check for thermal for backwards compatibility @JackB-Ansys could you please check this is working as intended?

I wasn't sure how to add the checks so let me know if there's a better way to do it How can you test if it's working with thermal without having 25R1?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (9c35ada) to head (3de6a06).

:exclamation: Current head 3de6a06 differs from pull request most recent head 5541eba

Please upload reports for the commit 5541eba to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #327 +/- ## ========================================== - Coverage 83.98% 83.65% -0.34% ========================================== Files 20 20 Lines 1936 1945 +9 ========================================== + Hits 1626 1627 +1 - Misses 310 318 +8 ```
jgsdavies commented 1 month ago

Need to add unit testing. See test_save_load_results() in ''test_general.py'''

This needs re-adding with thermal results too. Let me know if you want any more info with this.