anthonycaccese / minui-menu-es-de

A translation of the MinUI menu interface (originally designed and created by Shaun Inman) for ES-DE v3.0.3
1 stars 2 forks source link

Knulli / retrobat #1

Closed ajmandourah closed 2 months ago

ajmandourah commented 3 months ago

Hey.

This is really clean. Thanks for your effort.

I wonder if this can be ported to ES in batocera like knulli and such . I looked around in their themeing structure and it seems difficult . one option is to use a grid but i am not sure (mainly for system view as there is no system list in batocera version )

what do you think ?

anthonycaccese commented 3 months ago

I would prefer to keep it in a list structure to make sure it tries to stay as close as possible to the source it was inspired by... otherwise I am not sure it could be called MinUI Menu =)

Bato may have added the ability to use textlists on system view but its not documented yet so I haven't been able to check. Also there are a bunch of ES-DE theme engine features used in this theme that I am not sure Bato would support so that would require some digging.

anthonycaccese commented 3 months ago

Realized I didn't say... I do want to explore it =)

Its on my list just not sure when I will get to it.

ajmandourah commented 3 months ago

I would prefer to keep it in a list structure to make sure it tries to stay as close as possible to the source it was inspired by... otherwise I am not sure it could be called MinUI Menu =)

Bato may have added the ability to use textlists on system view but its not documented yet so I haven't been able to check. Also there are a bunch of ES-DE theme engine features used in this theme that I am not sure Bato would support so that would require some digging.

this sounds great. from where did you get the information that they have implemented textlist in system view? this is great as it will help creating minimalistic themes.

I dunno if you have experimented with grids. I haven't but im kinda optimistic . a 1x10 grid theoritically can create a list.

we will see.

Thanks for your time

anthonycaccese commented 3 months ago

I saw it in this PR: https://github.com/batocera-linux/batocera-emulationstation/pull/1657

ajmandourah commented 2 months ago

reading the cpp code in the pr I have succeded in getting a text list system view. I will try to somehow port your theme to batocera in general . I must say the tags were non intuitive. its mainly using this in a system view

<textlist name="textlist">
anthonycaccese commented 2 months ago

sorry I am not sure I follow what you mean by "I must say the tags were non intuitive."

ajmandourah commented 2 months ago

It's just seems weird where other text lists named "gamelist". This should be named system list for example

anthonycaccese commented 2 months ago

odd, usually the name value can be whatever you like. will close this for now as an active item, we can continue to discuss here though.