search

aodn-archive / DELETE_ME_go-go-duck

NetCDF aggregation service
1 stars 0 forks source link

return status link #100

Closed danfruehauf closed 9 years ago

danfruehauf commented 9 years ago

GGD returns a status link after registering a job. Next step is to use this link in portal and display it to the user after he submits a job - so she can click on it without waiting for any emails.

danfruehauf commented 9 years ago

Ready to go again. Basically sets statusLink in the response after registering a job.

danfruehauf commented 9 years ago

@jkburges Is that what you were after?

Tests will fail, but I'll fix them + add more after you confirm this is what you were after...

jkburges commented 9 years ago

Is that what you were after?

Yes, this is pretty much what I had in mind. I think this is much cleaner.

danfruehauf commented 9 years ago

@jkburges Indeed. Let me just wrestle with tests and also drive the notification service from the JobPresenter.

danfruehauf commented 9 years ago

Ready for review. Also uses JobPresenter in NotificationService to generate URLs.

danfruehauf commented 9 years ago

Or... Hold on, don't merge yet, but please do review if you can.

jkburges commented 9 years ago

This is GTG (tests pending), good work :+1:

danfruehauf commented 9 years ago

@jkburges Looks like I gonna get busy, so I'll leave it as is without the NotificationService refactor. It's definitely doable - but will take time. However feel free to do it as we actually got allocated for it.

jkburges commented 9 years ago

I'll take a look at the refactor, it'll be a separate PR.