[Improvement]: align term 'transaction' with Iceberg 'snapshot'

apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.

https://amoro.apache.org/

Apache License 2.0

869 stars 289 forks source link

[Improvement]: align term 'transaction' with Iceberg 'snapshot' #2751

Open link3280 opened 6 months ago

link3280 commented 6 months ago

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, snapshots are called transactions both in the codebase and the web UI, but under the hood they're the same for Iceberg users (perhaps some functionalities improvement for mixed formats).

I proposed to rename transactions to snapshots, which is more understandable for new users.

How should we improve?

No response

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

[X] I agree to follow this project's Code of Conduct

majin1102 commented 6 months ago

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing.... You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

link3280 commented 6 months ago

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing.... You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

@majin1102 Thanks for your input. I suppose you mean add-on transaction capabilities (e.g. transaction blockers) provided by mixed formats? But if I understand correctly there's no fundamental difference.

github-actions[bot] commented 6 days ago

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.