apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.
https://amoro.apache.org/
Apache License 2.0
817 stars 273 forks source link

[Improvement]: Add skip-trino-build profile #2853

Closed xleoken closed 3 months ago

xleoken commented 3 months ago

Search before asking

What would you like to be improved?

It not friendly for users to use mvn clean package -DskipTests -pl '!amoro-mixed-format/amoro-mixed-format-trino' to build the amoro project. Add a new skip-trino-build profile to improve the build command.

How should we improve?

No response

Are you willing to submit PR?

Subtasks

No response

Code of Conduct

zhoujinsong commented 3 months ago

Thanks a lot for bringing up this improvement.

The old maven command is indeed quite complex to use. But actually, most of the time, we do not need to build the amoro-mixed-format-trino module as it dependent on a different JDK version. So how about adding a profile named build-mixed-format-trino and inactive it by default?

So you can:

xleoken commented 3 months ago

@zhoujinsong you are right, I'll think about it again.