apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.
https://amoro.apache.org/
Apache License 2.0
748 stars 261 forks source link

[AMORO-2932] fix prometheus exporter issues in helm chart #2933

Closed XBaith closed 1 week ago

XBaith commented 2 weeks ago

Why are the changes needed?

Close #2932 .

Brief change log

How was this patch tested?

Documentation

baiyangtx commented 2 weeks ago

In this PR, can we simply handle the problem and only adapt helm charts for promethues?

metricReporters:
    promethues-exporter:
        enabled: true
        port: 7001
        properties: ~

and in deployment.yaml

          ports:
            - name: rest
              containerPort: {{ .Values.server.rest.port }}
            - name: table
              containerPort: {{ .Values.server.table.port }}
            - name: optimizing
              containerPort: {{ .Values.server.optimizing.port }}
            {{- include "amoro.pod.container.ports" . | nindent 8 }}

and we can manager port in _pod.tpl

{{- define "amoro.pod.container.ports" -}}
            - name: rest
              containerPort: {{ .Values.server.rest.port }}
            - name: table
              containerPort: {{ .Values.server.table.port }}
            - name: optimizing
              containerPort: {{ .Values.server.optimizing.port }}
{{- if .Values.metricRepoerters.promethuesExporter.enabled -}} 
            - name: promethues
              containerPort: {{ .Values.metricRepoerters.promethuesExporter.port }}
{{- end -}}
{{- end -}}
XBaith commented 2 weeks ago

@baiyangtx PTAL

zhoujinsong commented 1 week ago

Thanks for the work. @XBaith Thanks for the review. @baiyangtx