Closed xleoken closed 3 months ago
We cannot review the contents of the compressed package, which may be risky. Can we specify the pull this common method through http get it ?
We cannot review the contents of the compressed package, which may be risky. Can we specify the pull this common method through http get it ?
emm, it seems no other ways. I used gcp to download the dependency.
It's not a good idea to add a tgz
file to git repo.
Maybe you can build the amoro helm package in an environment where the network allows it and then distribute it to the environment where it needs to be deployed
Or Amoro can maintain built helm charts. Currently, the Amoro project provides packaged charts in gh-pages, but this branch is not maintained. Perhaps you can add a workflow to maintain this distribution
It's not a good idea to add a
tgz
file to git repo.Maybe you can build the amoro helm package in an environment where the network allows it and then distribute it to the environment where it needs to be deployed
ok, let me think again.
@baiyangtx @czy006
I copied some templates files from bitnami/charts
repository.
like doris did. https://github.com/apache/doris/blob/a831aabac493195d0048eaf8c0b21c77bb8bd674/be/src/vec/functions/function_quantile_state.cpp#L17
This problem has been bothering me for a long time, nice to see that this issue is resolving.
It's also difficult for me to download the common dependency.
Is it possible to put these files into a separate directory?
Good idea, updated.
Thanks for the work! @xleoken Thanks for the review! @baiyangtx
Why are the changes needed?
Close #2938.
Brief change log
Due to the network issue, it's very very hard for us to pull the common dependency from
registry-1.docker.io
. We can add the dependency to the project directly.How was this patch tested?
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[x] Run test locally before making a pull request
Documentation