apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.
https://amoro.apache.org/
Apache License 2.0
849 stars 278 forks source link

[AMORO-2938] Add common dependency chart #2939

Closed xleoken closed 3 months ago

xleoken commented 3 months ago

Why are the changes needed?

Close #2938.

Brief change log

Due to the network issue, it's very very hard for us to pull the common dependency from registry-1.docker.io. We can add the dependency to the project directly.

# helm dependency build
Error: no repository definition for oci://registry-1.docker.io/bitnamicharts. Please add the missing repos via 'helm repo add'

# ping registry-1.docker.io
PING registry-1.docker.io (54.196.99.49) 56(84) bytes of data.

How was this patch tested?

Documentation

czy006 commented 3 months ago

We cannot review the contents of the compressed package, which may be risky. Can we specify the pull this common method through http get it ?

xleoken commented 3 months ago

We cannot review the contents of the compressed package, which may be risky. Can we specify the pull this common method through http get it ?

emm, it seems no other ways. I used gcp to download the dependency. 17abdb54e2c452564174295c9aa70a5

baiyangtx commented 3 months ago

It's not a good idea to add a tgz file to git repo.

Maybe you can build the amoro helm package in an environment where the network allows it and then distribute it to the environment where it needs to be deployed

baiyangtx commented 3 months ago

Or Amoro can maintain built helm charts. Currently, the Amoro project provides packaged charts in gh-pages, but this branch is not maintained. Perhaps you can add a workflow to maintain this distribution

xleoken commented 3 months ago

It's not a good idea to add a tgz file to git repo.

Maybe you can build the amoro helm package in an environment where the network allows it and then distribute it to the environment where it needs to be deployed

ok, let me think again.

xleoken commented 3 months ago

@baiyangtx @czy006

I copied some templates files from bitnami/charts repository.

like doris did. https://github.com/apache/doris/blob/a831aabac493195d0048eaf8c0b21c77bb8bd674/be/src/vec/functions/function_quantile_state.cpp#L17

daragu commented 3 months ago

This problem has been bothering me for a long time, nice to see that this issue is resolving.

kristgpt commented 3 months ago

It's also difficult for me to download the common dependency.

xleoken commented 3 months ago

Is it possible to put these files into a separate directory?

Good idea, updated.

image

zhoujinsong commented 3 months ago

Thanks for the work! @xleoken Thanks for the review! @baiyangtx