Closed XBaith closed 2 weeks ago
Thanks for the contribution!
I am curious if the database username and password information is still needed in the configMap as we declare it in the environment.
some codes in amoro-configmap.yaml:
database:
type: {{ .Values.amoroConf.database.type }}
jdbc-driver-class: {{ .Values.amoroConf.database.driver | quote }}
url: {{ .Values.amoroConf.database.url }}
{{- if or (eq .Values.amoroConf.database.type "mysql") (eq .Values.amoroConf.database.type "postgres") }}
username: {{ .Values.amoroConf.database.username | quote }}
password: {{ .Values.amoroConf.database.password | quote }}
{{- end }}
connection-pool-max-total: 20
connection-pool-max-idle: 16
connection-pool-max-wait-millis: 1000
I am curious if the database username and password information is still needed in the configMap as we declare it in the environment.
You are right, we don't need to declare database password in ConfigMap
You are right, we don't need to declare database password in ConfigMap
We can improve this with another PR.
Why are the changes needed?
Brief change log
How was this patch tested?
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[x] Run test locally before making a pull request
Documentation