Closed baiyangtx closed 1 week ago
Code refactor, as we already have InternalServerCatalog, some methods in the TableService interface is not needed anymore.
-
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[ ] Run test locally before making a pull request
The changes look good to me. But it seems some unit tests should be modified to adapt to the change. @baiyangtx
Fixed @zhoujinsong
Why are the changes needed?
Code refactor, as we already have InternalServerCatalog, some methods in the TableService interface is not needed anymore.
Brief change log
-
How was this patch tested?
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[ ] Run test locally before making a pull request
Documentation