[Improvement] Redirect to login page if user doesn't login

apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.

https://amoro.apache.org/

Apache License 2.0

875 stars 291 forks source link

[Improvement] Redirect to login page if user doesn't login #3274

Open chouchouji opened 1 month ago

chouchouji commented 1 month ago

Why are the changes needed?

Close #xxx.

Brief change log

https://github.com/user-attachments/assets/9e824467-de8b-41ff-8b4d-e225a2244054

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

zhoujinsong commented 1 month ago

Thanks for the work!

When I tested it in my local environment, I got some unexpected errors: When I try to open http://127.0.0.1:1630/overview page without logging, it can redirect to the login page, but after I fill in the username and password and click sign in, it cannot redirect to the overview page.

chouchouji commented 1 month ago

logging

It may be a bug, I will fix it in recent days.

majin1102 commented 1 month ago

Thanks for this contribution.

It really helps much. I used to meet this issue img_v3_02fj_47eaa5b9-fd87-4e32-a86e-e025eea48d6g

When backend restarted, refresh would encounter this plenty of errors. Will they disappear after this PR merged? @chouchouji

czy006 commented 3 weeks ago