search

apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.
https://amoro.apache.org/
Apache License 2.0
875 stars 291 forks source link

[AMORO-3277] enable jvm parameter ExitOnOutOfMemoryError and HeapDumpOnOutOfMemoryError for ams #3278

Closed 7hong closed 1 month ago

7hong commented 1 month ago

Why are the changes needed?

Close #3277 .

zhoujinsong commented 1 month ago

Thanks for the contribution, @7hong

I agree that we should add the ExitOnOutOfMemoryError by default to improve the availability of AMS.

However, I am not quite sure if HeapDumpOnOutOfMemoryError should be enabled by default. As far as I know, this parameter can incur significant storage overhead, which may lead to some risks. Would it be more appropriate for us to enable it manually only when necessary?

Users can add extra JVM parameters in conf/jvm.properties.

7hong commented 1 month ago

Yes, HeapDumpOnOutOfMemoryError is enabled in my environment. The hprof file generated when OOM occurs takes up 10G of storage. hen we do not enable HeapDumpOnOutOfMemoryError by default. Users can enable it themselves if necessary.