apache / amoro

Apache Amoro (incubating) is a Lakehouse management system built on open data lake formats.
https://amoro.apache.org/
Apache License 2.0
874 stars 290 forks source link

[AMORO-3309][Improvement] Support for terminal integration with LDAP authentication in Kyuubi #3309

Closed Aireed closed 2 weeks ago

Aireed commented 3 weeks ago

Why are the changes needed?

Close #xxx. Support for terminal integration with LDAP authentication in Kyuubi

Brief change log

-

How was this patch tested?

Documentation

Aireed commented 3 weeks ago

When LDAP is enabled, how is authentication information passed to Kyuubi?

image

Referring to this configuration manual, you can directly include the username and password in the URL

tcodehuber commented 3 weeks ago

@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml https://github.com/apache/amoro/blob/master/charts/amoro/values.yaml

Aireed commented 2 weeks ago

@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml https://github.com/apache/amoro/blob/master/charts/amoro/values.yaml

I have updated the commition, PTAL. 3ks

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.16%. Comparing base (f13f3f3) to head (5bf9a66). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../terminal/kyuubi/KyuubiTerminalSessionFactory.java 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3309 +/- ## ============================================ - Coverage 30.17% 30.16% -0.02% Complexity 3840 3840 ============================================ Files 580 580 Lines 48020 48037 +17 Branches 6207 6210 +3 ============================================ Hits 14488 14488 - Misses 32542 32559 +17 Partials 990 990 ``` | [Flag](https://app.codecov.io/gh/apache/amoro/pull/3309/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [core](https://app.codecov.io/gh/apache/amoro/pull/3309/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `30.16% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zhoujinsong commented 2 weeks ago

Thanks for the contribution!