Closed Aireed closed 2 weeks ago
When LDAP is enabled, how is authentication information passed to Kyuubi?
Referring to this configuration manual, you can directly include the username and password in the URL
@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml https://github.com/apache/amoro/blob/master/charts/amoro/values.yaml
@Aireed Can you also improve the helm charts? This can make us enable this feature easily. refs: https://github.com/apache/amoro/blob/master/charts/amoro/templates/amoro-configmap.yaml https://github.com/apache/amoro/blob/master/charts/amoro/values.yaml
I have updated the commition, PTAL. 3ks
Attention: Patch coverage is 0%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 30.16%. Comparing base (
f13f3f3
) to head (5bf9a66
). Report is 4 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
.../terminal/kyuubi/KyuubiTerminalSessionFactory.java | 0.00% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the contribution!
Why are the changes needed?
Close #xxx. Support for terminal integration with LDAP authentication in Kyuubi
Brief change log
-
How was this patch tested?
[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
[ ] Add screenshots for manual tests if appropriate
[ ] Run test locally before making a pull request
Documentation