search

apache / incubator-devlake

Apache DevLake is an open-source dev data platform to ingest, analyze, and visualize the fragmented data from DevOps tools, extracting insights for engineering excellence, developer experience, and community growth.
https://devlake.apache.org/
Apache License 2.0
2.6k stars 526 forks source link

[Bug][DORA Dashboard] Metrics don't honor time-range #3662

Closed keon94 closed 1 year ago

keon94 commented 2 years ago

Search before asking

What happened

Looks like the dashboard is insensitive to time-ranges and pulls data from the last 6 months regardless of what the user sets.

What do you expect to happen

Metrics from the specified time interval needs to be shown/calculated.

How to reproduce

Collect DORA metrics from any datasource (I was testing my PagerDuty plugin), and specify a custom time-range.

See screenshot. I set it to 15 mins, but it goes all the way back to 22/06. image

Anything else

No response

Version

main

Are you willing to submit PR?

Code of Conduct

Startrekzky commented 2 years ago

Hey @keon94 , there're a few cases here.

  1. For time-series charts like Number of Deployments, I created a series of calendar months for the last six months and used it to join the actual data; if not, the months with no deployment would not be shown in the X-axis. In this case, the X-axis will always display the last six months, so the metrics does not honor time-range by design. image

    Improvements

    Instead of adding time-range filter here, how about rename Number of Deployments to Number of Deployments [Last six months]?

  2. For text charts like Deployment Frequency, the SQL takes the FROM date to create calendar dates to calculate if Deployment Frequency falls into daily, weekly or monthly. In this case, the deployments being calculated are filtered by the generated calendar dates. image

    Improvements

    Any suggestions? @keon94

  3. For text charts like Lead Time for Changes, Median Time to Restore Service and Change Failure Rate, the SQL takes the time-range. image

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] commented 1 year ago

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.