search

apache / incubator-devlake

Apache DevLake is an open-source dev data platform to ingest, analyze, and visualize the fragmented data from DevOps tools, extracting insights for engineering excellence, developer experience, and community growth.
https://devlake.apache.org/
Apache License 2.0
2.57k stars 516 forks source link

[Refactor][DORA] Refactor CalculateChangeLeadTimeMeta subtask #7557

Closed sstojak1 closed 3 months ago

sstojak1 commented 4 months ago

What and why to refactor

What are you trying to refactor? Why should it be refactored now? CalculateChangeLeadTimeMeta subtask is slow when there are a lot of records in the tables that are used to calculate the needed metrics that will eventually end up in the 'project_pr_metrics' table. Queries that are slow for us are the ones that are called in getFirstCommit and getFirstReview methods. They are querying pull_request_commits and pull_request_comments tables. Our fix was to add an index to pull_request_id on both tables.

Describe the solution you'd like

How to refactor? Introduce index by pull_request_id for pull_request_commits and pull_request_comments tables.

Related issues

Please link any other

Additional context

Add any other context or screenshots about the feature request here.

sstojak1 commented 4 months ago

If you think that adding an index makes sense, you can assign the task to me

sstojak1 commented 4 months ago

@d4x1 PR created.