adding pull_request_id index to pull_request_commits/comments tables

apache / incubator-devlake

Apache DevLake is an open-source dev data platform to ingest, analyze, and visualize the fragmented data from DevOps tools, extracting insights for engineering excellence, developer experience, and community growth.

https://devlake.apache.org/

Apache License 2.0

2.57k stars 516 forks source link

adding pull_request_id index to pull_request_commits/comments tables #7559

Closed sstojak1 closed 3 months ago

sstojak1 commented 4 months ago

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[ ] I have read through the Contributing Documentation.
[ ] I have added relevant tests.
[ ] I have added relevant documentation.
[ ] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do? Adding pull_request_id index to pull_request_commits and pull_request_comments tables.

Does this close any open issues?

Closes 7557

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

sstojak1 commented 4 months ago

Why are two tables handled differently? Besides, can we support postgresql as well? Apache DevLake supports pg as a storage option.

Those two tables don't have the same primary key definition. That's the reason why migration scripts are different.

Is the PostgreSQL supported? There are also a few scripts where this kind of schema check is added... Also, check this out: https://devlake-io.slack.com/archives/C03APJ20VM4/p1713164942109869 https://devlake-io.slack.com/archives/C03APJ20VM4/p1716386100745249

sstojak1 commented 3 months ago

Hi @klesh any updates here? Did you manage to check my last comment?

klesh commented 3 months ago

@sstojak1 Hi, sorry for the late reply. We support using PostgreSQL as a storage option for advanced users who prefer writing their own dashboards without any preset dashboards. In other words: the devlake implementation written in Golang supports both PG and Mysql while the embedded dashboards for grafana only available for Mysql

klesh commented 3 months ago

@sstojak1 And yes, we have some scripts designated MySQL, sometimes because they are MySQL specific nuances, which were unnecessary for PG from what I know.

sstojak1 commented 3 months ago

@klesh makes sense, thanks for the info. I have added support for PostgreSQL. Please take a look. Result when locally running Devlake with PostgreSQL:

klesh commented 3 months ago

Hi, @sstojak1 we are so close, there is one conflict left before I can merge the PR. Would you like to resolve it? Thanks.

sstojak1 commented 3 months ago

@klesh done!

sstojak1 commented 3 months ago

@klesh can we merge it? :)

abeizn commented 2 months ago

@sstojak1 Already released in v1.0.1-beta3