refactor: hudson.maven.MavenModuleSet is now treated as a scope

[sstojak1]

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

• [ ] I have read through the Contributing Documentation.
• [ ] I have added relevant tests.
• [ ] I have added relevant documentation.
• [ ] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do? hudson.maven.MavenModuleSet Jenkins pipeline will now be treated as a scope

Does this close any open issues?

Closes 7598

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

[d4x1]

@sstojak1 Have you tested it ? And it works as expected? Please help to fix the CI errors(https://devlake.apache.org/community/MakingContributions/development-workflow#commit-tool This doc will help). Thanks.

[klesh]

Looks good to me in terms of a fix. I wonder if it would make more sense to make scope the default? That is, to only match for groups and let the others be scope by default?

[klesh]

@sstojak1 BTW, are you interested in joining Apache as a Committer? I would like to invite you if you are up for it. Please reach me out on Slack if you do, my name is "Klesh Wong" on the channel.

[sstojak1]

@klesh makes sense to have scope as a default since there should be more jobs that should be treated as scope then group. I've tweaked the logic a bit by blending the new and old approaches. Please review. WorkflowMultiBranchProject is unique—it has jobs but should be considered as 'scope', hence the extra check in isGroup.

[klesh]

@gustavobini Would you like to take a look at the code? Thanks in advance.

[gustavobini]

@gustavobini Would you like to take a look at the code? Thanks in advance.

We had talked over Slack about this. It's a good solution. Thanks @sstojak1

[klesh]

Thank you all.