Add missing migration script to register.go

apache / incubator-devlake

Apache DevLake is an open-source dev data platform to ingest, analyze, and visualize the fragmented data from DevOps tools, extracting insights for engineering excellence, developer experience, and community growth.

https://devlake.apache.org/

Apache License 2.0

2.6k stars 528 forks source link

Add missing migration script to register.go #8178

Closed sstojak1 closed 2 weeks ago

sstojak1 commented 3 weeks ago

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[x] I have read through the Contributing Documentation.
[ ] I have added relevant tests.
[ ] I have added relevant documentation.
[ ] I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do? Adds increaseProjectKeyLength and changeIssueComponentType to register.go

Does this close any open issues?

Closes #8177

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

sstojak1 commented 2 weeks ago

@klesh can we merge it?

klesh commented 2 weeks ago

@sstojak1 Could you fix the test cases?

sstojak1 commented 2 weeks ago

@klesh, 20240813_change_issue_component_type is fixed. Could you run the tests again?

Before that, could you review the 20240813_increase_project_key_length script? It might fail since the project_key column doesn’t exist in cq_projects. Did you intend to modify a different column?

klesh commented 2 weeks ago

@sstojak1 I just checked the code and found out 20240813_increase_project_key_length under the core/model should be changing the length of cq_projects.id from 255 to 500 instead. Would you kindly update the script to do so? Thanks, 🌹

sstojak1 commented 2 weeks ago

@klesh updated...

klesh commented 2 weeks ago

@sstojak1 Thank you very much for correcting my mistakes 🌹 I wondered why people kept reporting "Data too long" after my PR merged.

sstojak1 commented 2 weeks ago

I was almost one of them until I did a bit of troubleshooting 😅