apache / incubator-devlake

Apache DevLake is an open-source dev data platform to ingest, analyze, and visualize the fragmented data from DevOps tools, extracting insights for engineering excellence, developer experience, and community growth.
https://devlake.apache.org/
Apache License 2.0
2.61k stars 528 forks source link

fix(backend): update Makefile to include version prefix in go-dep command #8194

Closed rodrigoluizs closed 6 days ago

rodrigoluizs commented 1 week ago

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

Summary

Fixes the issue in the go-dep make command where the version prefix was missing, ensuring consistent dependency installation.

How to Reproduce?

cd backend
make go-dep                                                                        
go install github.com/vektra/mockery/v2@2.43.0
go: github.com/vektra/mockery/v2@2.43.0: github.com/vektra/mockery/v2@2.43.0: invalid version: unknown revision 2.43.0
make: *** [go-dep] Error 1
klesh commented 6 days ago

Thanks for your contribution. Would you like to submit another PR to the release-v1.0 branch so is can be released faster?

rodrigoluizs commented 6 days ago

of course, I'll do it.

rodrigoluizs commented 5 days ago

@klesh here we go: https://github.com/apache/incubator-devlake/pull/8197

klesh commented 3 days ago

Nice, merged