search

apache / rocketmq-mqtt

Apache rocketmq
https://rocketmq.apache.org/
Apache License 2.0
181 stars 63 forks source link

[ISSUE #70] Retained message based on raft state machine #131

Closed YYYYWD closed 1 year ago

YYYYWD commented 2 years ago

70

ShannonDing commented 2 years ago

link #118

ShannonDing commented 2 years ago

the GID separator has been changed from "=" to "%", rebase the latest develop branch and merge the PR #129 .

YYYYWD commented 2 years ago

the GID separator has been changed from "=" to "%", rebase the latest develop branch and merge the PR #129 .

Using % can cause unpredictable errors, so use "-" instead

DongyuanPan commented 2 years ago

@YYYYWD Y Using % can cause unpredictable errors, so use "-" instead. it can make a new pr to develop

DongyuanPan commented 2 years ago

Does the state machine need to care about message content? Or use byte array storage directly, reducing serialization and deserialization. Trie tree retainedMsgTopicTrie in state machine also has the same problem

DongyuanPan commented 2 years ago

To facilitate troubleshooting, you need to add error logs

codecov-commenter commented 2 years ago

Codecov Report

Merging #131 (ca54807) into develop (af04be9) will decrease coverage by 1.93%. The diff coverage is 17.79%.

@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
- Coverage    41.96%   40.02%   -1.94%     
===========================================
  Files          119      122       +3     
  Lines         4904     5314     +410     
  Branches       714      764      +50     
===========================================
+ Hits          2058     2127      +69     
- Misses        2491     2824     +333     
- Partials       355      363       +8
Impacted Files Coverage Δ
...org/apache/rocketmq/mqtt/meta/config/MetaConf.java 0.00% <0.00%> (ø)
...apache/rocketmq/mqtt/meta/raft/MqttRaftServer.java 0.00% <0.00%> (ø)
...ache/rocketmq/mqtt/meta/raft/MqttStateMachine.java 0.00% <0.00%> (ø)
...e/rocketmq/mqtt/meta/raft/processor/Constants.java 0.00% <ø> (ø)
...qtt/meta/raft/processor/CounterStateProcessor.java 0.00% <0.00%> (ø)
...meta/raft/processor/RetainedMsgStateProcessor.java 0.00% <0.00%> (ø)
...ketmq/mqtt/meta/raft/processor/StateProcessor.java 0.00% <ø> (ø)
...ocketmq/mqtt/common/hook/AbstractUpstreamHook.java 21.05% <ø> (ø)
...g/apache/rocketmq/mqtt/common/model/Constants.java 0.00% <ø> (ø)
...pache/rocketmq/mqtt/common/model/Subscription.java 77.14% <0.00%> (-4.68%) :arrow_down:
... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

DongyuanPan commented 2 years ago

Please adjust the code style, remove extra blank lines, and add spaces around certain symbols

DongyuanPan commented 2 years ago

@ShannonDing @pingww it can be merged

pingww commented 1 year ago

to resolve conflicts