search

apocalyptech / eschalon_utils

Eschalon Books I, II, and III Character and Map Editors
http://apocalyptech.com/eschalon/
GNU General Public License v2.0
8 stars 3 forks source link

Migrate from getopt to argparse for maps #85

Closed grimreaper closed 6 years ago

apocalyptech commented 6 years ago

Hello again!

I'm definitely onboard with moving from getopt to argparse - I always cringe a bit whenever I see something of mine which didn't use argparse - but I'm not sure about collapsing down all the map scripts into a single one, and using arguments.

One thing that I'd want to address before actually going ahead with it is the Windows packaging - the vast majority of users of this thing were on Windows, I believe, and it was pretty trivial to package it up into separate executables on there. I definitely wouldn't want to have to make Windows users jump on a CLI, so I'd want to at least figure out packaging up shortcuts somehow, if it's all combined.

I'd probably also at least set up little wrapper shell scripts or aliases for myself, so I could continue launching 'em simply. (Not that I use these things much anymore, alas.)

One thing I could absolutely get onboard with would be at least making the entry point scripts far thinner. Have just a couple lines in each which all filter into a common argument-parsing and setup area.

Anyway, my rambling point is that I'll probably hold off on merging this one, at least until I've had an opportunity to mull it over some more.

Thanks for all the pulls, though! :)

grimreaper commented 6 years ago

Couldn't windows users primarily use the eschalon_utils.py ?

apocalyptech commented 6 years ago

Oh bother, you're right. It's been years since I've even launched it on there anyway.

I'll just go ahead and merge this in.