search

apocalyptech / eschalon_utils

Eschalon Books I, II, and III Character and Map Editors
http://apocalyptech.com/eschalon/
GNU General Public License v2.0
8 stars 3 forks source link

Convert to GobjectIntrospection and Python 3 #95

Closed grimreaper closed 6 years ago

grimreaper commented 6 years ago

@apocalyptech I wanted to get your take on this. I've been working on porting the GUI to gi, and all the code to python 3. At this point it seems reasonable to merge into master.

This might also make it possible to make another release.

grimreaper commented 6 years ago

@apocalyptech - something is weird with how github pull requests works but this is still a real request

apocalyptech commented 6 years ago

Hah, yeah, weird! Anyway: I haven't actually looked at your commits in awhile and was wondering if gtk->gi was in the cards, so that's hardly surprising. I'd say go ahead and merge it! Anyone using the github code directly should expect some code churn anyway, if there's still latent issues which haven't been found out or patched yet.

In a related note, I did want to make sure to tell you to slap your name in the copyright lines on the files, and into the Credits, etc (I think the util has a Credits somewhere, yeah?) As far as I'm concerned, you've got a much stronger claim to ownership of the current codebase than I do. Theoretically I'd love to resume hacking away at this, but realistically I doubt I'm going to end up finding the time to do so, so I'm quite comfortable basically handing the project over to you, if you want.

As for a release, I'm also willing to trust your judgement on that one! If it'd make sense to release this thing (even in a -pre state, or something like that), I'd be all about it. I'd be happy to assist with that, though that's also another area that I'd be comfortable handing off to you if you want. It shouldn't be hard to give you SSH access to the webserver and write access into the web subdir (the web code is actually also at github at https://github.com/apocalyptech/eschalon_utils_web/, though since earlier this year the PHP code isn't entirely standalone). Alternatively, if you'd felt like having the website at a location that you've got more direct control over, I'd be comfortable setting up a redirect or whatever to point at something of your own.

But regardless, more immediately: sure, merge it!

-CJ