search

appirio-tech / topcoder-app-r

Topcoder pages in React and Redux
0 stars 3 forks source link

label is wrongly placed for some search text #46

Open winterflame opened 8 years ago

winterflame commented 8 years ago

Mac 10.11.4 + FF45.0.1

  1. open https://www.topcoder-qa.com/search/members/?q=acRush
  2. observe

expected: the label should be put on the top of the results table

actual: see screenshot qq20160409-54 2x

callmekatootie commented 8 years ago

It's a feature - iirc, if there is an exact match, then it shows the user itself - no title needed in such a case

winterflame commented 8 years ago

@callmekatootie It shows the label as "Usernames matching acrush - 2 results", but there is only one result below the label, which is a bit confusing.

I still think it needs to be redesigned no matter if it has an exact match, please reconsider. Thanks!

nlitwin commented 8 years ago

I had thought about this as well, but forgot to mention it when building it. @fnisen @vic-appirio Is this working as expected or is it a valid bug?

fnisen commented 8 years ago

@callmekatootie, @nlitwin - let's give credit for this one. Even if we don't need the label at the top, the label on the second component should still be corrected.

nlitwin commented 8 years ago

TODO: If exact match exists, show "Other usernames matching" for the list container header text and show one fewer than the actual number of list items.