applepi-2067 / 2023_Robot

Code for 2067's 2023 Robot

Other

6 stars 0 forks source link

fix voltage limit code #84

Closed jcorcoran closed 1 year ago

jcorcoran commented 1 year ago

Description

use the output of the limit function
remove the setter for voltage limit that was overriding the value for max_voltage_open_loop

Root cause of not being able to up the voltage limit was the 2nd bullet (default value hard coded in the annotation)

Wholesale removed the setter since it's not really used in practice.

Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Bugfix (non-breaking change which fixes an issue, add DEF # above in description)
[ ] Environment change (changes to developer environment or CI configuration)
[ ] Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Tested on stand-alone dev board

Author Checklist:

[x] I have performed a self-review of my code
[x] I have added 1-2 reviewers
[ ] I have @mentioned relevant non-reviewers as an FYI
[x] I have included a detailed description of my changes and their motivations