apu52 / Travel_Website

πŸš€ Welcome🌈 , This repo is officially accepted for IEEE-IGDTUW Open Source Week 2024🌟This repo contains my project on Travel Website ✈️ using HTML,CSS . It contains the landing page of a travel tour company website. If you have any front end project on this or you can add new features in the project or in this repos.
https://apu52.github.io/Travel_Website/
MIT License
302 stars 591 forks source link

fix: Add valid email checker while subscribing #1557

Closed Ishika-Gupta06 closed 3 weeks ago

Ishika-Gupta06 commented 1 month ago

Title : valid Email while Subscribing

Issue No. : #1547

Code Stack : html, JavaScript

Close #1547

Description

improve the regex to ensure the domain part is properly validated (e.g., at least two characters after the dot). Added an email validation regex (email Pattern) to check the input format. If the email is valid, the success message is displayed. If the email is invalid, an error message is displayed for 4 seconds.

Video/Screenshots (mandatory)

https://github.com/user-attachments/assets/313757b3-5674-4068-b16a-e7f806f403f8

Type of PR

Checklist:

netlify[bot] commented 1 month ago

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
Latest commit d9eb3117c713a18dd19665d6f0b8a22a5d951ecc
Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6716487290b2dc0008b10b99
Deploy Preview https://deploy-preview-1557--taupe-cendol-f7e2bb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IRONalways17 commented 1 month ago

This pull request includes changes to the index.html file to improve the user experience and validation for the subscription form. The most important changes include adding an error message for invalid email addresses, improving the email validation regex, and refactoring the JavaScript code for better readability and functionality.

User Experience Improvements:

Validation Enhancements:

Code Refactoring:

Ishika-Gupta06 commented 4 weeks ago

@apu52 kindly review the PR

github-actions[bot] commented 3 weeks ago

πŸŽ‰πŸŽ‰ Thank you for your contribution! Your PR #1557 has been merged! πŸŽ‰πŸŽ‰