apu52 / Travel_Website

πŸš€ Welcome🌈 , This repo is officially accepted for GSSOC'2k24🌟 & VsOC'24🌟This repo contains my project on Travel Website ✈️ using HTML,CSS . It contains the landing page of a travel tour company website. If you have any front end project on this or you can add new features in the project or in this repos.
https://apu52.github.io/Travel_Website/
MIT License
191 stars 412 forks source link

feat: Added social media links #893

Closed Saipradyumnagoud closed 1 week ago

Saipradyumnagoud commented 1 week ago

Title and Issue number

Title :Added social media links

Issue No. : #892

Code Stack :

Close #892

Description

I have added social media links

Video/Screenshots (mandatory)

image

Type of PR

Checklist:

Additional context:

Are you contributing under any Open-source programme?

netlify[bot] commented 1 week ago

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
Latest commit a7a61175ae7d2d4d58b92e384eaf485351f69a3a
Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667da3c2a084ec0008dc8bbc
Deploy Preview https://deploy-preview-893--taupe-cendol-f7e2bb.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Saipradyumnagoud commented 1 week ago

@apu52 can you please review soon

Saipradyumnagoud commented 1 week ago

@itsekta can you please review it πŸ™πŸΎ

Saipradyumnagoud commented 1 week ago

@apu52 Now please go through the pull request

itsekta commented 1 week ago

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

Saipradyumnagoud commented 1 week ago

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

Yes sure i will work on it

Saipradyumnagoud commented 1 week ago

image

Saipradyumnagoud commented 1 week ago

@apu52 @itsekta made the required changes requested

itsekta commented 1 week ago

@Saipradyumnagoud, why are the icons getting smaller on hover

Saipradyumnagoud commented 1 week ago

@Saipradyumnagoud, why are the icons getting smaller on hover

Should i make icons bigger on hover

itsekta commented 1 week ago

Your choice, you can make a little bigger (scale 0.5) or don't just the ui should look nice.

Saipradyumnagoud commented 1 week ago

@itsekta yes now i have made please check

itsekta commented 1 week ago

Nice

Saipradyumnagoud commented 1 week ago

Nice

@itsekta can you please merge the pull request

itsekta commented 1 week ago

@apu52 will be merging it

Saipradyumnagoud commented 1 week ago

@apu52 will be merging it

Yes make it soon