apu52 / Travel_Website

🚀 Welcome🌈 , This repo is officially accepted for GSSOC'2k24🌟 & VsOC'24🌟This repo contains my project on Travel Website ✈️ using HTML,CSS . It contains the landing page of a travel tour company website. If you have any front end project on this or you can add new features in the project or in this repos.

https://apu52.github.io/Travel_Website/

MIT License

186 stars 407 forks source link

feat: FAQ Page inproved #926

Open sau-mili opened 5 days ago

sau-mili commented 5 days ago

Title and Issue number

Title :

Issue No. : #909

Code Stack : HTML, CSS, JS

Close #909

Description

Added new accordion system to the page
Added navabar
Edited minute bugs in index.html file
Also CSS for the FAQ page is done

Video/Screenshots (mandatory)

NOW

https://github.com/apu52/Travel_Website/assets/146661411/d7752167-e4d3-49bd-8d06-9153859d8d9c

Screenshot 2024-06-28 010907

BEFORE

Screenshot 2024-06-28 010414

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___

Checklist:

[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have gone through the contributing.md file before contributing

Additional context:

Are you contributing under any Open-source programme?

[x] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

netlify[bot] commented 5 days ago

Deploy Preview for taupe-cendol-f7e2bb ready!

Name	Link
Latest commit	93f66f666e55d834d568bc32ad31a209f32bcf77
Latest deploy log	https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667dc148ef573d0008eafb2f
Deploy Preview	https://deploy-preview-926--taupe-cendol-f7e2bb.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

itsekta commented 4 days ago

Hey @sau-mili, have you checked the UI on the preview link above. The UI for FAQ now looks like this

This can be improved with a nice UI

sau-mili commented 4 days ago

The one that you shared is on the home page, and I edited the specific “Faqs” page. Do you want me to edit the home page as well?

itsekta commented 4 days ago

The one that you shared is on the home page, and I edited the specific “Faqs” page. Do you want me to edit the home page as well?

Okay got it, just checked the faq page nice work 👍

itsekta commented 4 days ago

Improved FAQ page PR #926

sau-mili commented 4 days ago

What’s wrong then? What do i need to improve?

itsekta commented 4 days ago

Nothing is wrong, I have just closed the issues as you have already created a pull request that is #926

sau-mili commented 4 days ago

But it was not merged. That’s why asking

itsekta commented 4 days ago

These PR will be merged by Project admin only when he get the time to merge, Don't worry they will be merged