aquasecurity / aqua-helm

Helm Charts For Installing Aqua Security Components
http://aquasec.com
Apache License 2.0
87 stars 184 forks source link

Web Service Pods named Incorrectly as "aqua-web-ssl" #841

Open nishadali opened 4 months ago

nishadali commented 4 months ago

As per the below service YAML definition, 443 is mapped for 8443 which is designed as the grpc port on wich gateway connects to console.

`
service: type: LoadBalancer

Specify loadBalancerIP address for aqua-gateway in AKS platform

loadbalancerIP: ""
labels: {}
annotations: {}
ports:
  - name: aqua-web
    port: 8080
    targetPort: 8080
    nodePort:
    protocol: TCP
    # uncomment to support appProtocol for SCP L7 LBs.
   #        appProtocol: http
  - name: **aqua-web-ssl**
    port: 443
    targetPort: 8443
    nodePort:
    protocol: TCP

`

As this is named as aqua-web-ssl, its confusing to the users reviewing the chart, I think renaming to aqua-web-gateway or some other name that highlight its use case will be helpfull

https://github.com/aquasecurity/aqua-helm/blob/e35f9da7d750353d3a72c471a46af543038f0c49/server/values.yaml#L362