search

arch1t3cht / Aegisub

Cross-platform advanced subtitle editor, with new feature branches. Read the README on the feature branch.
http://www.aegisub.org
Other
695 stars 32 forks source link

bestsource: Bump to R4 #125

Closed 0tkl closed 1 month ago

0tkl commented 3 months ago

Since https://github.com/arch1t3cht/Aegisub/commit/900876cc7f6ddc93368c965fa13a51553b5bc705 there’s quite a lot progress in the upstream, especially the meson.build got overhauled. So removing avs/vs plugin by patch are no longer needed since https://github.com/vapoursynth/bestsource/commit/477a7f5b3836c99125faa3e433b483387899bbbc; and the link_static option become prefer_static since https://github.com/vapoursynth/bestsource/commit/d59b689e78fc98be54af37a47408a92daff741ad.

I'm a total amateur to all the decoding internals so the only thing I check is API changes. AFAIK the only difference after https://github.com/arch1t3cht/Aegisub/commit/900876cc7f6ddc93368c965fa13a51553b5bc705 is a new cachemode parameter introduced in https://github.com/vapoursynth/bestsource/commit/ae446223a513480561ccc14bacf4da0eafd97ee7.

arch1t3cht commented 3 months ago

Thanks for the PR, but soon after the commit bestsource is currently pinned to, the headers started to use std::filesystem::path, which needs C++17 (while arch1t3cht/Aegisub is still C++11). So this can't be merged right now (and IMO the differences from the current commit to R2 aren't big enough to warrant hacks like making a small C++17 wrapper library to work around this).

TypesettingTools/Aegisub has already switched to C++20, and I plan to eventually figure out how to rebase my changes on top of that - when that's done this PR can be merged.

0tkl commented 1 month ago

Merged in https://github.com/arch1t3cht/Aegisub/commit/0a01ecf9cef52ab05432dd04ddf99ae4a380cc9b